@gtanzillo is this the removal of the code developed with @chargio ? if so, I would like to discuss that before it is removed. /cc @Fryguy

That's correct, this is the removal of the "Chargio" integration. I'll make this PR WIP so that we can discuss

It is a pity but I understand why you don't want to have code that you are not using.

I still believe that this code is faster and easier to maintain that the existing one, though.

we need to remove also those methods():

ChargeableField#showback_measure
ChargeableField#showback_dimension

Chargeback#showback_category
ChargebackRateDetail#showback_unit

but I think your reason was to just unplugging consumption repo(those methods became just dead code after merging this PR) - so I can do it in follow up 👍

otherwise looks good to me 👍 Thanks!

The code will still be in the repo so we can always bring it back. However, right now, that repo has failing tests with no one to fix them, and the maintenance burden is high for something we are not actually using.

@lpichler I'm assuming that we would also need a migration to remove all of the showback_* tables.

Checked commits gtanzillo/manageiq@6e3dc43~...59fc065 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
5 files checked, 0 offenses detected
Everything looks fine. 🍪

This seems ready to go, so can it be un-WIP-ed?

I spoke to @chessbyte around this and we was good with it as long as it's just decoupling. Since manageiq-consumption repo will still exist, we can always bring this back in the future.

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation.

This pull request is not mergeable. Please rebase and repush.

@gtanzillo I didn't realize this code was at a mergeable state - can you rebase?

@Fryguy are you sure we want to remove this? I thought that this was the strategic direction for chargeback.

@Fryguy See #19550 (comment) - While there are no failing tests at the moment, it is still a maintenance overhead.